Core: cull events from multidata spheres #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
beauxq
reviewed
Jul 6, 2024
Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
Exempt-Medic
added
the
is: enhancement
Berserker66
added
waiting-on: core-review
NewSoupVi
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Currently, when using say !hint worlds with heavy use of events get pushed back in priority. This recursively culls events out while making the spheres, giving them similar priority.
The feature, at least on the Sphere Tracker, is told to the user to only look at sendable items, so it makes sense for the feature to consistently work that way to meet user expectations.
How was this tested?
locally. I had 1 HK and 1 LTTP with set seed, it turned 42 spheres, of which many spheres were one-player only, into 15 spheres in which both players had things to send, which is closer to what I'd expect.
If this makes graphical changes, please attach screenshots.
:( -> :)